Re: [PATCH 1/1] POWERPC: Fix ppc32 compile with gcc+SSP in 2.6.16

[John Mylchreest]

On Sun, Apr 02, 2006 at 04:49:37PM +0200, Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:
> On Sun, 2006-04-02 at 14:56 +0100, John Mylchreest wrote:
> > On Sun, Apr 02, 2006 at 03:15:38PM +0200, Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:
> > > 
> > > > Going from that, I can push a patch for gcc upstream to remove the
> > > > __KERNEL__ dep, but gcc4.1 ships with ssp by standard, and the semantics
> > > > between the IBM patch for SSP applied to gcc-3 and ggc-4 have changed.
> > > > 
> > > > -fno-stack-protector would work for gcc4, but for gcc3 it could still be
> > > 
> > > since this is a thing you have to turn on to get it, not off to not get
> > > it, I think you're missing something big here ;)
> > > 
> > > > patially enabled, and requires -fno-stack-protector-all. Mind If I ask
> > > > whats incorrect about defining __KERNEL__ for the bootcflags?
> > > 
> > > it's silly and it's a non-standard gcc ... better get the gcc fixed to
> > > at least have the upstream protocol of having to turn it on not off..
> > 
> > It gets turned on elsewhere (gcc spec),
> 
> ehh???
> so you change gcc to force a specific, non-standard option on, and
> something breaks as a result... better get the gcc spec fixed I'd say 

Yeah, something which I completely disregarded without thinking about
until this thread. Always helps not looking at this at 1am ;)
I always thought the arch/boot code should stay as part of the kernel
build. I'll re-address :)

Cheers for the input.

-- 
Role:            Gentoo Linux Kernel Lead
Gentoo Linux:    http://www.gentoo.org
Public Key:      gpg --recv-keys 9C745515
Key fingerprint: A0AF F3C8 D699 A05A EC5C  24F7 95AA 241D 9C74 5515

Attachment: pgp00000.pgp
Description: PGP signature