Re: [PATCH] sbp2: fix spinlock recursion

From: Andrew Morton
Date: Sat Apr 01 2006 - 19:50:59 EST


Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> wrote:
>
> @@ -2540,6 +2537,7 @@ static int sbp2scsi_abort(struct scsi_cm
> command->Current_done(command->Current_SCpnt);
> }
> }
> + spin_unlock_irqrestore(&scsi_id->sbp2_command_orb_lock, flags);

This changes the call environment for all implementations of
->Current_done(). Are they all safe to call under this lock?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/