Re: [PATCH][RFC] splice support

From: Nick Piggin
Date: Thu Mar 30 2006 - 13:55:03 EST


Jens Axboe wrote:
On Thu, Mar 30 2006, Andrew Morton wrote:

Maybe the code handles that by making sure that all the pages in the range
are already in pagecache - I didn't check. But that would take some heroic
locking.


It doesn't, I'm assuming that find_get_pages() returns consequtive pages
atm. Would seem like the sane interface :-)


It doesn't.

You could do a find_get_pages_and_holes (or something along those
lines), which would fetch contiguous pagecache and stick NULLs
if pages don't exist.

Would require a bit of radix-tree support to do it nicely, but you
could get started with a naive find_get_page loop.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/