Re: [Patch 5/8] generic netlink interface for delay accounting

[Shailabh Nagar]

Balbir Singh wrote:

> Hi, Andrew
>
>
> On Wed, Mar 29, 2006 at 09:04:06PM -0800, Andrew Morton wrote:
>  
>
> > Shailabh Nagar <nagar@xxxxxxxxxxxxxx> wrote:
> >    
> >
> > > delayacct-genetlink.patch
> > >
> > > Create a generic netlink interface (NETLINK_GENERIC family),
> > > called "taskstats", for getting delay and cpu statistics of
> > > tasks and thread groups during their lifetime and when they exit.
> > >
> > >
> > >
> > >      
<snip>

> > > +
> > > +static int __init taskstats_init(void)
> > > +{
> > > +	if (genl_register_family(&family))
> > > +		return -EFAULT;
> > >      
> > EFAULT?
> >    
>
> It shouldn't be (Shailabh please comment). We will fix it.
>  
Sorry, it should return the  value returned by genl_register_family.

I copied the code from net/tipc/netlink.c
where a similarly erroneous errno is being used. We'll submit a fix
for that as well.

--Shailabh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/