Re: [PATCH] inotify: IN_DELETE events missing in -mm

From: John McCutchan
Date: Wed Mar 29 2006 - 16:34:23 EST


On Wed, 2006-29-03 at 10:57 -0500, Amy Griffis wrote:
> In recent -mm kernels (e.g. 2.6.16-mm1), IN_DELETE events are no longer
> generated for the removal of a file from a watched directory.
>
> This seems to be a result of clearing DCACHE_INOTIFY_PARENT_WATCHED in
> d_delete() directly before calling fsnotify_nameremove().
>
> Assuming the flag doesn't need to be cleared before dentry_iput(), this should
> do the trick.

I took a quick look at nick's patch again, and it doesn't seem to
require the flag being cleared before dentry_iput. This looks good to
me. Nick?

--
John McCutchan <john@xxxxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/