Re: [PATCH] loop: potential kernel hang waiting for kthread

From: Christoph Hellwig
Date: Sat Mar 25 2006 - 06:22:37 EST


On Sat, Mar 25, 2006 at 02:49:32AM +0100, Herbert Poetzl wrote:
>
> Hi Andrew! Folks!
>
> just stumbled over the following issue with loop_set_fd()
> calling kernel_thread(loop_thread), ignoring the return
> value, even if it is an error, then doing wait_for_completion()
> on the device, which, in beforementioned error case, would
> wait forever (keeping a process stuck in 'D' state)
>
> I can imagine at least three other solutions, but this
> one seemed quite organic to me, YMMV ...

Best thing would be to switch it to the kthread_ API.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/