Re: [ALSA] ISA drivers bailing on first !enable[i]

[Takashi Iwai]

At Fri, 24 Mar 2006 06:32:50 +0100,
Rene Herman wrote:
> 
> Hi Takashi.
> 
> After the change to the platform_driver stuff in 2.6.16, all ISA card
> module_inits loop over the cards using:
> 
> 	for (i = 0; i < SNDRV_CARDS && enable[i]; i++) {
> 
> This means that the driver bails completely on the first !enable[i].
> This did not use to be the case and does not seem right. I believe it
> should rather be:
> 
> 	for (i = 0; i < SNDRV_CARDS; i++) {
> 		if (!enable[i])
> 			continue;
> 
> This would restore the previous behaviour for the enable parameter; ie,
> only ignore the one.
> 
> Assuming this was indeed the idea, I've attached a patch against 2.6.16.
> If it's correct, but you need it against ALSA CVS instead, please say so

Yes, these are correct fixes.  Most of them should have been already
in the latest ALSA tree, i.e. also in Linus git tree now.

Could you check what's still missing?  I might missed some drivers.


Thanks.

Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/