RE: [PATCH] Clean up magic numbers in i2c_parport.h

From: Christopher Hoover
Date: Thu Mar 23 2006 - 23:43:40 EST



> Beeuh. These macros don't really help. They actually make the lines
longer! I'm not taking this change, sorry.

If I kill off the macros but continue to use C99 structure initializers,
which is I believe is the proper kernel coding style today, the lines are
going to get even longer. Is that OK?

Or are you asking for the patch w/o macros and w/o C99 structure
initializers?

I can/will do either. Just let me know what is acceptable a priori.

-ch

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/