Re: [RFC, PATCH 5/24] i386 Vmi code patching

[Andi Kleen]

On Monday 13 March 2006 19:02, Zachary Amsden wrote:
> The VMI ROM detection and code patching mechanism is illustrated in
> setup.c.  There ROM is a binary block published by the hypervisor, and
> and there are certainly implications of this.  ROMs certainly have a
> history of being proprietary, very differently licensed pieces of
> software, and mostly under non-free licenses.  Before jumping to the
> conclusion that this is a bad thing, let us consider more carefully
> why hiding the interface layer to the hypervisor is actually a good
> thing.

How about you fix all these issues you describe here first 
and then submit it again?

The disassembly stuff indeed doesn't look like something
that belongs in the kernel.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/