Re: [PATCH 10 of 20] ipath - support for userspace apps using coredriver

From: Bryan O'Sullivan
Date: Wed Mar 22 2006 - 12:50:54 EST


On Wed, 2006-03-22 at 17:46 +0000, Hugh Dickins wrote:

> Ah, great, then I needn't look through your code, phew (no offence)!

Indeed :-)

> That may well be a good plan (given the doubts Nick raised about
> whether dma_alcohol_rent gives the right kind of struct page non-slab
> memory on all arches).

Well, it Works For Me (TM) right now. Thank goodness. And the driver
is about 200 lines shorter without the nopage handler and consequent
mucking about.

> But one way in which the stars will be slightly
> misaligned: for 2.6.14 and earlier you'll need to SetPageReserved on
> each constituent of the >0-page, to get remap_pfn_range to map it (and
> ClearPageReserved before freeing the >0-page); that won't do any harm
> on 2.6.15 and 2.6.16 (apart from enlarging the code unnecessarily);
> but we might one day remove those macros, from driver use anyway.

Yes, we're already doing this. So far, I've tested on 2.6.12, 2.6.15,
and 2.6.16 using remap_pfn_range, and everything appears to be
cromulent.

<b

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/