Re: [RFC PATCH 35/35] Add Xen virtual block device driver.

From: Christoph Hellwig
Date: Wed Mar 22 2006 - 11:52:01 EST


On Wed, Mar 22, 2006 at 10:39:25AM -0600, Anthony Liguori wrote:
> This is another thing that has always put me off. The virtual block
> device driver has the ability to masquerade as other types of block
> devices. It actually claims to be an IDE or SCSI device allocating the
> appropriate major/minor numbers.
>
> This seems to be pretty evil and creating interesting failure conditions
> for users who load IDE or SCSI modules. I've seen it trip up a number
> of people in the past. I think we should only ever use the major number
> that was actually allocated to us.

Exactly. We vetoed crap like that in the ibm vio drivers already so
it was removed before merging those drivers.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/