Re: [PATCH 2.6.16-rc6] i2c: require type parameter for i2c-parportand i2c-parport-light

From: Jean Delvare
Date: Wed Mar 22 2006 - 07:31:26 EST


Hi Mark,

> This patch forces the user to specify what type of adapter is present when
> loading i2c-parport or i2c-parport-light. If none is specified, the driver
> init simply fails - instead of assuming adapter type 0.
>
> This alleviates the sometimes lengthy boot time delays which can be caused
> by accidentally building one of these into a kernel along with several i2c
> slave drivers that have lengthy probe routines (e.g. hwmon drivers).
>
> Kconfig and documentation updated accordingly.

Good patch, thanks, I've applied it. The only change I made is:

> + * (type=5) Analog Devices evaluation boards: ADM1025, ADM103[01]

I expanded it to "ADM1025, ADM1030, ADM1031", because I think it's
important to be able to just grep chip names in the documentation files
(or source code, for that matter.)

Thanks,
--
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/