Re: [git patches] libata updates

From: Alan Cox
Date: Mon Mar 20 2006 - 11:26:38 EST


On Llu, 2006-03-20 at 06:16 -0500, Jeff Garzik wrote:
> Jeff Garzik:
> [libata] Move PCI IDE BMDMA-related code to new file libata-bmdma.c.

This is a most confusing choice as 80% of the file has nothing to do
with bus mastering DMA, and a large amount of it has nothing to do with
PCI either. Also lots of DMA stuff is in the drivers so all the new bus
mastering drivers don't use bmdma.c

The split makes sense, the choice of name is peculiar, if not completely
broken 8)

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/