Re: [PATCH] udf: fix uid/gid options and add uid/gid=ignore and forgetoptions

From: Phillip Susi
Date: Mon Mar 20 2006 - 11:24:54 EST


Andrew Morton wrote:
I didn't see that update, and I don't miss much.


See http://lkml.org/lkml/2006/3/5/171

Please provide a description of this change. What problem is it fixing? How does it fix it? What are the consequences of not making this change?

In the initial patch I made a typo. As Pekka Enberg pointed out, with the if still following the else, you can still get a null uid written to the disk if you specify a default uid= without uid=forget. In other words, if the desktop user is uid=1000 and the mount option uid=1000 is given ( which is done on ubuntu automatically and probably other distributions that use hal ), then if any other user besides uid 1000 owns a file then a 0 will be written to the media as the owning uid instead. This is exactly what the original patch was trying to prevent.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/