Re: [PATCH]micro optimization of kcalloc

[Oliver Neukum]

Am Montag, 20. März 2006 16:14 schrieb Benjamin LaHaise:
> On Mon, Mar 20, 2006 at 03:45:23PM +0100, Oliver Neukum wrote:
> >  static inline void *kcalloc(size_t n, size_t size, gfp_t flags)
> >  {
> > -	if (n != 0 && size > INT_MAX / n)
> > +	if (unlikely(size != 0 && n > INT_MAX / size ))
> >  		return NULL;
> >  	return kzalloc(n * size, flags);
> >  }
> 
> This function shouldn't be inlined.  We have no need to optimize the 
> unlikely case like this.

The likely case is passing constants. Without inlining precisely the
likely case cannot be optimised.

	Regards
		Oliver
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/