Re: [patch] latency-tracing-v2.6.16

[Wu Fengguang]

On Mon, Mar 20, 2006 at 11:13:07AM +0100, Ingo Molnar wrote:
> i've released the latency-tracer patch for v2.6.16:
> 
>    http://redhat.com/~mingo/latency-tracing-patches/latency-tracing-v2.6.16.patch
 
Thanks, it helps a lot :)

> max scheduling latencies can be tracked via the enabling of 
> CONFIG_WAKEUP_TIMING. Tracking can be started via the resetting of the 
> max latency:
> 
> 	echo 0 > /proc/sys/kernel/preempt_max_latency
> 
> if CONFIG_LATENCY_TRACE is enabled too then an execution trace will be 
> automatically generated as well, accessible via /proc/latency_trace.

In fact that is not enough.
In include/asm-i386/timex.h, get_cycles() is defined as

        static inline cycles_t get_cycles (void)
        {
                unsigned long long ret=0;
        
        #ifndef CONFIG_X86_TSC
                if (!cpu_has_tsc)
                        return 0;
        #endif
        
        #if defined(CONFIG_X86_GENERIC) || defined(CONFIG_X86_TSC)
                rdtscll(ret);
        #endif
                return ret;
        }

If one (as I did at the first attempt) selects a CPU type of
"586/K5/5x86/6x86/6x86MX", he will get nothing from /proc/latency_trace.

So does it make sense to add dependency lines like the following one?

        depends on (!X86_32 || X86_GENERIC || X86_TSC)

Cheers,
Wu
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/