Re: 2.6.16-rc5-mm2: IPW_QOS: two remarks

[John W. Linville]

On Sun, Mar 05, 2006 at 01:46:26AM +0100, Andreas Happe wrote:

> Add the following config entries for the ipw2200 driver to 
> drivers/net/wireless/Kconfig
>  * IPW2200_MONITOR
> 	enables Monitor mode, as this seems to generate lots of firmware errors
> 	it depends upon BROKEN
>  * IPW2200_QOS
> 	enables QoS feature - this is under development right now, so it depends 
> 	upon EXPERIMENTAL.

Your patch appears to be whitespace-damaged.  Please configure your
mailer appropriately.

Also, please stick to the patch format described here:

	http://linux.yyz.us/patch-format.html

In particular, don't put anything in the message that doesn't belong
in the kernel's changelog, such as email-ish messages.

On Tue, Mar 07, 2006 at 06:06:42PM +0100, Adrian Bunk wrote:
> On Sun, Mar 05, 2006 at 01:46:26AM +0100, Andreas Happe wrote:
> > On Friday 03 March 2006 16:26, Adrian Bunk wrote:
> >...
> > > - please add a help text
> > 
> > i could add some stuff about WMM to its help text, but I think someone more 
> > involved with the ipw2200-project should do that.
> 
> Even a short help text is better than no help text.

I agree w/ Adrian.  Since you are touching it, please put something
appropriate in the Kconfig file.  Zhu Yi may be able to help if you
aren't sure what the help text should say.

Thanks!

John
-- 
John W. Linville
linville@xxxxxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/