Re: [PATCH: 012/017]Memory hotplug for new nodes v.4.(rebuildzonelists after online pages)

From: Dave Hansen
Date: Fri Mar 17 2006 - 12:56:35 EST


On Fri, 2006-03-17 at 17:22 +0900, Yasunori Goto wrote:
> +++ pgdat8/mm/memory_hotplug.c 2006-03-17 13:53:40.712581399 +0900
> @@ -123,6 +123,7 @@ int online_pages(unsigned long pfn, unsi
> unsigned long flags;
> unsigned long onlined_pages = 0;
> struct zone *zone;
> + int need_refresh_zonelist = 0;

I'd make this "need_to_rebuild_zonelists" or "need_zonelists_rebuild".
I think those sound a little bit better.

Plus, it makes even more sense when you see:

if (need_to_rebuild_zonelists)
build_all_zonelists();

if the names all match up.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/