Re: [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register

From: Greg KH
Date: Thu Mar 16 2006 - 18:44:43 EST


On Thu, Mar 16, 2006 at 03:37:22PM -0800, Roland Dreier wrote:
> Greg> As msi.c today is pretty platform-specific as is, I don't
> Greg> have a problem with moving the ia64 stuff also into that
> Greg> directory. Especially as it will help solve issues like
> Greg> this a lot better.
>
> I think we really want to make drivers/pci/msi.c less
> platform-specific. Both powerpc and sparc64 are starting to pay
> attention to MSI, so we should really be trying to move things in the
> direction of a clean separation of generic MSI handling and
> Intel-specific bits.

Oh I completely agree. It's just that the efforts so far to do this has
caused a big #include mess that we are currently in. And I don't think
that putting pci core structures in the include/linux/ directory is the
correct solution. If others can come up with cleaner splits of the
code, I incourage it.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/