Re: [patch 1/1] consolidate TRUE and FALSE

[Christoph Hellwig]

On Thu, Mar 16, 2006 at 08:29:51AM -0800, Randy.Dunlap wrote:
> On Thu, 16 Mar 2006 16:01:30 +0000 Christoph Hellwig wrote:
> 
> > > The patch implements TRUE and FALSE in include/linux/kernel.h and removes all
> > > the private versions.
> > > 
> > > The patch also kills off a few private implementations of NULL.
> > 
> > NACK.  Just kill them all and use 0/1
> 
> nah, the only place that using symbolic names for true and false
> is a problem is when someone #defines or enums them bassackwards.

it makes the code longer and harder to read.  there's a reason the core
code doesn't use it, and the periphal code should do the same.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/