Re: [PATCH] modpost: fix buffer overflow

From: Andreas Schwab
Date: Wed Mar 15 2006 - 10:34:28 EST


Jiri Benc <jbenc@xxxxxxx> writes:

> + while (buf->size - buf->pos < len + 1)
> + buf->size += 128;

What's wrong with

buf->size = buf->pos + len + 1;

Andreas.

--
Andreas Schwab, SuSE Labs, schwab@xxxxxxx
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/