Re: [2.6.16-rc6 patch] remove sleep_avg multiplier

[Con Kolivas]

On Tuesday 14 March 2006 21:05, Con Kolivas wrote:
> On Tuesday 14 March 2006 20:56, Ingo Molnar wrote:
> > * Mike Galbraith <efault@xxxxxx> wrote:
> > > Greetings,
> > >
> > > The patchlet below removes the sleep_avg multiplier.  This multiplier
> > > was necessary back when we had 10 seconds of dynamic range in
> > > sleep_avg, but now that we only have one second, it causes that one
> > > second to be compressed down to 100ms in some cases.  This is
> > > particularly noticeable when compiling a kernel in a slow NFS mount,
> > > and I believe it to be a very likely candidate for other recently
> > > reported network related interactivity problems.
> > >
> > > In testing, I can detect no negative impact of this removal.  IMHO,
> > > this constitutes a bug-fix, and as such is suitable for 2.6.16.
> >
> > looks good to me. The biggest complaint against the current scheduler is
> > over-eager interactivity boosting - this patch moderates that in a
> > smooth way.
>
> I actually think Mike is right about the change, but has anyone else tested
> this patch to also confirm "it has no negative impact" warranting it's
> rapid inclusion in 2.6.16?

/me smacks himself for misusing "it's"

How about an interbench run before and after Mike?

Cheers,
Con
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/