Re: [Patch 9/9] Generic netlink interface for delay accounting

From: Shailabh Nagar
Date: Mon Mar 13 2006 - 23:26:34 EST


Matt Helsley wrote:

On Mon, 2006-03-13 at 19:56 -0500, Shailabh Nagar wrote:
<snip>



Comments addressed (all in response to Jamal)

- Eliminated TASKSTATS_CMD_LISTEN and TASKSTATS_CMD_IGNORE



The enums for these are still in the patch. See below.

<snip>



+/*
+ * Commands sent from userspace
+ * Not versioned. New commands should only be inserted at the enum's end
+ */
+
+enum {
+ TASKSTATS_CMD_UNSPEC, /* Reserved */
+ TASKSTATS_CMD_NONE, /* Not a valid cmd to send
+ * Marks data sent on task/tgid exit */
+ TASKSTATS_CMD_LISTEN, /* Start listening */
+ TASKSTATS_CMD_IGNORE, /* Stop listening */



From the description I thought you had eliminated these.



Yup, typo. the commands aren't registered but the enums hang on.
Will fix.

--Shailabh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/