Re: [RFC][PATCH] USB touch screen driver, all-in-one

[Lanslott Gish]

Hi, Daniel,

i fixed some codes and add swap_x & swap_y functions.
and test your patch passed for my touchset hrdware.
here is the patch only for your usbtouchscreen.c
could you help to apply this?
thank you.

Regards,

Lanslott Gish

==============================================================
--- linux-2.6.16-rc6.patched/drivers/usb/input/usbtouchscreen.c
+++ linux-2.6.16-rc6/drivers/usb/input/usbtouchscreen.c
@@ -224,13 +224,24 @@
  * PanJit Part
  */
 #ifdef CONFIG_USB_TOUCHSCREEN_PANJIT
+
+static int swap_x;
+module_param(swap_x, bool, 0644);
+MODULE_PARM_DESC(swap_x, "If set X axe is swapped before XY swapped.");
+static int swap_y;
+module_param(swap_y, bool, 0644);
+MODULE_PARM_DESC(swap_y, "If set Y axe is swapped before XY swapped.");
+
 static int panjit_read_data(char *pkt, int *x, int *y, int *touch, int *press)
 {
-       *x = pkt[1] | (pkt[2] << 8);
-       *y = pkt[3] | (pkt[4] << 8);
+       *x = (pkt[1] & 0x0F) | ((pkt[2]& 0xFF) << 8);
+       *y = (pkt[3] & 0x0F) | ((pkt[4]& 0xFF) << 8);
        *touch = (pkt[0] & 0x01) ? 1 : 0;

-       return 1;
+	if(swap_x) *x = *x ^ 0x0FFF;
+	if(swap_y) *y = *y ^ 0x0FFF;
+
+ 	return 1;
 }
 #endif

==============================================================



On 3/13/06, Lanslott Gish <lanslott.gish@xxxxxxxxx> wrote:
> Hi, Daniel,
> it's great. i will test touchset part today.
>
> Regards,
>
> Lanslott Gish
>
> On 3/12/06, Daniel Ritz <daniel.ritz-ml@xxxxxxxxxxxxxx> wrote:
> > hi
> >
> > here my merge of the USB touchscreen drivers, based on my patch from
> > thursday for touchkitusb. this time it's a new driver...
> >
> > and of course it's untested. i can test the egalax part next week...
> >
> > [ also cc'ing the authors of the other drivers ]
> >
> > the sizes for comparison:
> >    text    data     bss     dec     hex filename
> >    2942     724       4    3670     e56 touchkitusb.ko
> >    2647     660       0    3307     ceb mtouchusb.ko
> >    2448     628       0    3076     c04 itmtouch.ko
> >    4097    1012       4    5113    13f9 usbtouchscreen.ko
> >
> > comments?
> >
> > rgds
> > -daniel
> >
>


--
L.G, Life's Good~
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/