Re: [PATCH] Fix deadlock in RPC scheduling code.

From: Trond Myklebust
Date: Mon Mar 13 2006 - 11:06:12 EST


On Mon, 2006-03-13 at 16:16 +0100, Aurelien Degremont wrote:

> IMO, the code will still hang because, the list_for_each_entry_safe()
> loop will never complete, even with the new scheme. Indeed, the loop
> call __rpc_wake_up_task() will try to set RPC_TASK_WAKEUP bit, but it is
> already set by rpc_wake_up_task(), so it hangs...

Look again. There is nothing that loops in __rpc_wake_up_task(). If the
RPC_TASK_WAKEUP is already set, then the function exits.

Cheers,
Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/