Re: [PATCH] [PNP] 'modalias' sysfs export

[Kay Sievers]

On Sat, Mar 11, 2006 at 05:38:47PM -0800, Andrew Morton wrote:
> Pierre Ossman <drzeus-list@xxxxxxxxx> wrote:
> >
> >  Here is a patch for doing multi line modalias for PNP devices. This will
> >  break udev, so that needs to be updated first.
> > 
> >  I had a longer look at the card part and it seems that module aliases
> >  cannot be reliably used for it. Not without restructuring the system at
> >  least. The possible combinations explode when you notice that the driver
> >  ids needs to be just at subset of the card, without any ordering.
> > 
> >  If I got my calculations right, a PNP card would have to have roughly
> >  2^(2n) aliases, where n is the number of device ids. So right now, I
> >  lean towards only adding modalias support for the non-card part of the
> >  PNP layer.
> > 
> >  Andrew, do you want a fix for the patch in -mm or can you remove the
> >  part of it that modifies drivers/pnp/card.c by yourself?
> 
> I assume you mean that the drivers/pnp/card.c patch of
> pnp-modalias-sysfs-export.patch needs to be removed and this patch applies
> on top of the result.
> 
> But I don't want to break udev.

Right, we should not start multiline modalias sysfs files. Eighter we
get all aliases encoded in a single string, maybe like macio is doing it:
  http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;hb=HEAD;f=drivers/macintosh/macio_sysfs.c#l42
and we can pass that single string to modprobe, or we better stay with
the current one-line udev PNP rule which uses /bin/sh to do the job, which
works just fine.

Also MODALIAS in the event environment is required at the same time
the sysfs file is added. And that should also not be a multi-line
value.

Thanks,
Kay
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/