Re: [2.6 patch] net/decnet/dn_route.c: fix inconsequent NULL checking

From: Herbert Xu
Date: Fri Mar 10 2006 - 21:49:06 EST


Adrian Bunk <bunk@xxxxxxxxx> wrote:
> The Coverity checker noted this inconsequent NULL checking in
> dnrt_drop().
>
> Since all callers ensure that NULL isn't passed, we can simply remove
> the check.

Ack.

In fact it's pointless even if the caller didn't check as dst_release
checks it anyway.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/