Re: [PATCH] autofs4 - follow_link missing funtionality

[Andrew Morton]

Ian Kent <raven@xxxxxxxxxx> wrote:
>
> @@ -337,10 +340,34 @@ static void *autofs4_follow_link(struct 
>  	if (oz_mode || !lookup_type)
>  		goto done;
>  
> +	/*
> +	 * If the dentry contains directories then it is an
> +	 * autofs multi-mount with no root offset. So don't
> +	 * try to mount it again.
> +	 */
> +	spin_lock(&dcache_lock);
> +	if (!list_empty(&dentry->d_subdirs)) {
> +		spin_unlock(&dcache_lock);
> +		goto done;
> +	}
> +	spin_unlock(&dcache_lock);
> +

Can list_empty(&dentry->d_subdirs) become false right here, after the lock
was dropped?  If so, what happens?


>  	status = try_to_fill_dentry(dentry, 0);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/