[2.6 patch] drivers/usb/media/vicam.c: fix a NULL pointer dereference

[Adrian Bunk]

This patch fixes a NULL pointer dereference spotted by the Coverity 
checker.


Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

--- linux-2.6.16-rc5-mm3-full/drivers/usb/media/vicam.c.old	2006-03-10 20:54:17.000000000 +0100
+++ linux-2.6.16-rc5-mm3-full/drivers/usb/media/vicam.c	2006-03-10 20:54:44.000000000 +0100
@@ -758,18 +758,19 @@ vicam_open(struct inode *inode, struct f
 {
 	struct video_device *dev = video_devdata(file);
 	struct vicam_camera *cam =
 	    (struct vicam_camera *) dev->priv;
 	DBG("open\n");
 
 	if (!cam) {
 		printk(KERN_ERR
 		       "vicam video_device improperly initialized");
+		return -EINVAL;
 	}
 
 	/* the videodev_lock held above us protects us from
 	 * simultaneous opens...for now. we probably shouldn't
 	 * rely on this fact forever.
 	 */
 
 	if (cam->open_count > 0) {
 		printk(KERN_INFO

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/