Re: [PATCH -mm3] x86-64: Eliminate register_die_notifier symbol exported twice

[Kevin Winchester]

"Andrew Morton" <akpm@xxxxxxxx> wrote:
> "Randy.Dunlap" <rdunlap@xxxxxxxxxxxx> wrote:
> >
> > On Thu, 09 Mar 2006 19:44:59 -0400 Kevin Winchester wrote:
> >
> > >
> > > register_die_notifier is exported twice, once in traps.c and once in
> > > x8664_ksyms.c.  This results in a warning on build.
> > >
> > > Signed-Off-By: Kevin Winchester <kwin@xxxxxxxxxxxxxxx>
> > >
> > > --- v2.6.16-rc5-mm3.orig/arch/x86_64/kernel/x8664_ksyms.c
> > > 2006-03-09 19:34:11.000000000 -0400
> > > +++ v2.6.16-rc5-mm3/arch/x86_64/kernel/x8664_ksyms.c    2006-03-09
> > > 19:40:46.000000000 -0400
> > > @@ -142,7 +142,6 @@ EXPORT_SYMBOL(rwsem_down_write_failed_th
> > >  EXPORT_SYMBOL(empty_zero_page);
> > >
> > >  EXPORT_SYMBOL(die_chain);
> > > -EXPORT_SYMBOL(register_die_notifier);
> > >
> > >  #ifdef CONFIG_SMP
> > >  EXPORT_SYMBOL(cpu_sibling_map);
> >
> > Thanks for that.  However, I see 2 such warnings:
> >
> > WARNING: vmlinux: 'register_die_notifier' exported twice. Previous
export was in vmlinux
> > WARNING: vmlinux: 'strlen' exported twice. Previous export was in
vmlinux
> >
>
> They're all over the place.  Some of them are due to -mm-only patches.
>
> It's not very urgent.  Let's get Sam's stuff settled down into mainline
and
> get all such warnings in mainline fixed up first.  That way, people will
> then know when their new patches are being bad and I'll know when -mm
> patches need fixups.

Fixing warnings like this is about the extent of my kernel abilities, so I
figured I'd do it even if it isn't high priority.  I do get the strlen
warning as well, that was going to be tonight's task.

If it helps, I don't see any warnings on the -rc5 kernel.  These two are the
only ones I see.

Kevin


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/