Re: [PATCH] Fix scripts/namespace.pl portability

[Sam Ravnborg]

On Thu, Mar 09, 2006 at 03:40:30PM +0000, Ralf Baechle wrote:
> On Thu, Mar 09, 2006 at 01:01:50PM +0000, Ralf Baechle wrote:
> 
> > scripts/namespace.pl was assuming the nm and objdump tools to use are
> > always just named that which breaks things in a crosscompilation
> > environment.
> > 
> > Fixed by honouring $NM and $OBJDUMP if passed by make, otherwise
> > defaulting to just nm rsp. objdump just as we used to.
> > 
> > Signed-off-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> 
> Atsushi Nemoto pointed me to http://lkml.org/lkml/2005/9/20/68.  This
> old patch which seems more complete than mine but made it into the kernel.
>  I just refreshed the patch and added the bits to ensure namespace.pl
> uses the right nm binary also - Keith's original patch only fixed the
> objdump use.
> 
> From: Keith Owens <kaos@xxxxxxxxxx>
> 
> Those scripts are meant to work even when they are invoked by hand,
> without OBJDUMP being defined in the environment.  This is the correct
> fix.

Hi Ralf. In my kbuild tree I have this fixed already:
my $nm = ($ENV{'NM'} || "nm") . " -p";
my $objdump = ($ENV{'OBJDUMP'} || "objdump") . " -s -j .comment";

Patch is from Aaron Brooks.

The reference_init.pl + reference_discarded.pl are subject for removal
since the check has been moved to modpost.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/