Re: [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (updated patch)

From: Jan Blunck
Date: Thu Mar 09 2006 - 09:05:52 EST


On Thu, Mar 09, Kirill Korotaev wrote:

> >
> >Are we all happy with this patch now?
>
> I can't see why we fix shrink_dcache_parent() only, why
> shrink_dcache_anon() is totally missed?
>

First of all because anon-dentries don't have a parent. So they are not a real
problem in don't restarting the shrink_dcache_anon() if we waited for prunes.
Since I've reordered the calls to shrink_dcache_anon() and
shrink_dcache_parent() in generic_shutdown_super() they are handled as normal
dentries if they are pruned through shrink_dcache_memory() from the d_lru list.

Regards,
Jan

--
Jan Blunck jblunck@xxxxxxx
SuSE LINUX AG - A Novell company
Maxfeldstr. 5 +49-911-74053-608
D-90409 Nürnberg http://www.suse.de
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/