Re: [PATCH] Document Linux's memory barriers

[Nick Piggin]

Paul Mackerras wrote:
> David Howells writes:

> > +     The way to deal with this is to insert an I/O memory barrier between the
> > +     two accesses:
> > +
> > +	*ADR = ctl_reg_3;
> > +	mb();
> > +	reg = *DATA;
>
>
> Ummm, this implies mb() is "an I/O memory barrier".  I can see people
> getting confused if they read this and then see mb() being used when
> no I/O is being done.

Isn't it? Why wouldn't you just use smp_mb() if no IO is being done?

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/