Re: [PATCH] Prevent NULL pointer deref in grab_swap_token

From: Andrew Morton
Date: Tue Mar 07 2006 - 18:07:48 EST


Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> On Tue, Mar 07, 2006 at 03:13:44PM -0600, Dean Roe wrote:
> > grab_swap_token() assumes that the current process has an mm struct,
> > which is not true for kernel threads invoking get_user_pages(). Since
> > this should be extremely rare, just return from grab_swap_token()
> > without doing anything.
>
> There's a few things that will break if a kernel thread calls
> get_user_pages, so we should rather fix those.

What things will break? Anything which dinks with current->mm in or
under get_user_pages() is probably already broken.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/