Re: [PATCH 7/15] EDAC: i82875p cleanup

From: Henrique de Moraes Holschuh
Date: Tue Mar 07 2006 - 10:45:24 EST


On Tue, 07 Mar 2006, Wang Zhenyu wrote:
> On 2006.03.04 02:47:01 +0000, Dave Peterson wrote:
> > On Thursday 02 March 2006 18:30, Andrew Morton wrote:
> > > Dave Peterson <dsp@xxxxxxxx> wrote:
> > > > +#ifdef CORRECT_BIOS
> > > > +fail0:
> > > > +#endif
> > >
> > > What is CORRECT_BIOS? Is the fact that it's never defined some sort of
> > > commentary? ;)
> > I'm not sure about this. I'm cc'ing Thayne Harbaugh and Wang Zhenyu since
> > their names are in the credits for the i82875p module. Maybe they can
> > provide some info.
>
> You can take CORRECT_BIOS as "strict-pci-resource-reserve" for overflow device
> in 82875p, some bad BIOS does make it reserved, which cause pci_request_region()
> failed. Actually we never defined it.

Bad? :-) It would be bad only if they didn't *hide* the overflow device.
Regardless of the overflow device being hidden or not, that area is really
in use, and should be known to be in use. How can you know it is in use if
the device is hidden, unless the BIOS reserves it?

Let's call that "inconvenient" BIOSes instead...

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/