Re: [PATCH] 2.6.16-rc5-mm2 mpage_readpages() cleanup

[Andrew Morton]

Badari Pulavarty <pbadari@xxxxxxxxxx> wrote:
>
> Instead of passing validity of block mapping, do_mpage_readpage() 
>  can figure it out using buffer_mapped(). This will reduce one
>  un-needed argument passing.

Is buffer_mapped() the correct flag to use?  Remember that get_block() can
validly return a !buffer_mapped() bh over a file hole.

Either way, there should be a comment in there explaining the protocol,
please.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/