Re: [patch] fix hardcoded values in collie frontlight

From: Pavel Machek
Date: Mon Mar 06 2006 - 11:33:44 EST


> > @@ -93,11 +94,13 @@ void locomolcd_power(int on)
> > }
> >
> > /* read comadj */
> > + if (comadj == -1) {
> > #ifdef CONFIG_MACH_POODLE
> > - comadj = 118;
> > + comadj = 118;
> > #else
> > - comadj = 128;
> > + comadj = 128;
> > #endif
> > + }
>
> Perhaps use machine_is_poodle() and machine_is_collie() here?

Yep, and unneccesssary includes can be killed. Thanks.
Pavel

--
Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/