Re: emu10k1_synth use after free

From: Takashi Iwai
Date: Mon Mar 06 2006 - 08:47:50 EST


At Mon, 6 Mar 2006 03:53:17 -0500,
Dave Jones wrote:
>
> Thou shalt not dereference freed memory.
>
> Coverity bug #958
>
> Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
>
> --- linux-2.6/sound/pci/emu10k1/emu10k1_synth.c~ 2006-03-06 03:51:26.000000000 -0500
> +++ linux-2.6/sound/pci/emu10k1/emu10k1_synth.c 2006-03-06 03:51:36.000000000 -0500
> @@ -62,7 +62,6 @@ static int snd_emu10k1_synth_new_device(
>
> if (snd_emux_register(emu, dev->card, arg->index, "Emu10k1") < 0) {
> snd_emux_free(emu);
> - emu->hw = NULL;
> return -ENOMEM;
> }
>
>

Thanks, I applied it to ALSA tree, too.


Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/