Re: 9pfs double kfree

From: Dave Jones
Date: Mon Mar 06 2006 - 02:27:10 EST


On Mon, Mar 06, 2006 at 07:23:46AM +0000, Al Viro wrote:
> On Sun, Mar 05, 2006 at 11:07:11PM -0800, David S. Miller wrote:
> > From: Dave Jones <davej@xxxxxxxxxx>
> > Date: Mon, 6 Mar 2006 02:04:58 -0500
> >
> > > (I wish we had a kfree variant that NULL'd the target when it was free'd)
> >
> > Excellent idea.
>
> ITYM "poison the pointer variable". Otherwise that sort of crap will go
> unnoticed.

yeah, even better idea. Just like slab debug, but without the overhead
of poisoning the whole object.

I wonder if we could get away with something as simple as..

#define kfree(foo) \
__kfree(foo); \
foo = KFREE_POISON;

?

Dave

--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/