Re: [PATCH] define setup_arch() in header file

[Andrew Morton]

Ben Dooks <ben-linux@xxxxxxxxx> wrote:
>
> When running sparse over an ARM build of 2.6.16-rc5, I came
>  across this error, which is due to setup_arch() being used
>  be init/main.c, but not being defined in any headers.
> 
>  This patch adds setup_arch() definition to include/linux/init.h
> 
>  The warning is:
>    arch/arm/kernel/setup.c:730:13: warning: symbol 'setup_arch' was not declared. Should it be static?
> 
> ...
>
>  --- linux-2.6.16-rc5/include/linux/init.h	2006-02-28 09:05:02.000000000 +0000
>  +++ linux-2.6.16-rc5-fixes/include/linux/init.h	2006-03-05 20:39:21.000000000 +0000
>  @@ -69,6 +69,10 @@ extern initcall_t __security_initcall_st
>   
>   /* Defined in init/main.c */
>   extern char saved_command_line[];
>  +
>  +/* used by init/main.c */
>  +extern void setup_arch(char **);

There are already declarations of setup_arch in include/asm-ppc and
include/asm-powerpc.  Different declarations.

Plus there's an unneeded-with-this-patch declaration in init/main.c.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/