Re: [PATCH 1/1] EFI: Fix gdt load

[Andrew Morton]

Zwane Mwaikambo <zwane@xxxxxxxxxxxxxxxx> wrote:
>
> On Thu, 2 Mar 2006, Edgar Hucek wrote:
> 
> > This patch makes the kernel bootable again on ia32 EFI systems.
> > 
> > Signed-off-by: Edgar Hucek <hostmaster@xxxxxxxxxx>
> > 
> 
>  	spin_lock(&efi_rt_lock);
>  	local_irq_save(efi_rt_eflags);
> 
> That looks like a race, not to mention that efi_rt_eflags is a global 
> variable. The same strange ordering occurs on unlock, i presume this code 
> 'works' because it's done early during boot?

No, the code's OK.  This is the prologue function.  The epilogue function
does the opposite.   In between, this CPU will dink around with EFI stuff.

And the order is correct too - the lock protects efi_rt_eflags.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/