Re: 2.6.16-rc4-mm2: drivers/rtc/utils.c should become part of a generic implementation

[Adrian Bunk]

On Sun, Feb 26, 2006 at 08:02:12PM +0000, Russell King wrote:
> On Sun, Feb 26, 2006 at 07:55:18PM +0100, Adrian Bunk wrote:
> > On Sun, Feb 26, 2006 at 07:41:16PM +0100, Alessandro Zummo wrote:
> > > On Sat, 25 Feb 2006 14:10:25 +0100
> > > Adrian Bunk <bunk@xxxxxxxxx> wrote:
> > > 
> > > > 
> > > > Sounds good, but for generic functions, two adjustments are required:
> > > > - move the code to lib/
> > > > - remove rtc_ prefixes from the functions
> > > 
> > >  Moved. I'm not sure about renaming them.. 
> > > 
> > >  the functions are:
> > > 
> > > rtc_month_days
> > > rtc_time_to_tm
> > > rtc_valid_tm
> > > rtc_tm_to_time
> > > 
> > >  I think they make more sense with the rtc prefix
> > 
> > None of these functions is in any way specicific to RTC drivers.
> 
> Doesn't having them take a struct rtc_time (which is different from
> struct tm) make them rather RTC specific?

You are right, it seems I was a bit blind...

But in this case, it seems we don't need to build them unconditionally 
no matter whether RTC support is enabled in the kernel.

> Russell King

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/