Re: 2.6.16-rc5-mm1

[Andrew Morton]

"J.A. Magallon" <jamagallon@xxxxxxx> wrote:
>
> On Wed, 1 Mar 2006 02:32:35 -0800, Andrew Morton <akpm@xxxxxxxx> wrote:
> 
>  > 
>  > Useful, thanks.  So the second batch of /proc patches are indeed the problem.
>  > 
>  > If you have (even more) time you could test
>  > http://www.zip.com.au/~akpm/linux/patches/stuff/2.6.16-rc5-mm2-pre1.gz. 
>  > That's the latest of everything with the problematic sysfs patches reverted
>  > and Eric's recent /proc fixes.
>  > 
> 
>  I just tried rc5-mm1 and this. With this I can run java apps/applets again
>  without locking my system. 
> 
>  I also applied the patch you posted for inotify, but now I get this new one:
> 
>  Mar  1 15:11:04 werewolf kernel: [ 1424.891482] BUG: warning at fs/inotify.c:410/set_dentry_child_flags()

Which patch was that?  The first one was doubly broken.

This is closer.

diff -puN fs/dcache.c~inotify-lock-avoidance-with-parent-watch-status-in-dentry-fix fs/dcache.c
--- devel/fs/dcache.c~inotify-lock-avoidance-with-parent-watch-status-in-dentry-fix	2006-03-01 12:16:22.000000000 -0800
+++ devel-akpm/fs/dcache.c	2006-03-01 12:18:34.000000000 -0800
@@ -100,6 +100,7 @@ static void dentry_iput(struct dentry * 
 	if (inode) {
 		dentry->d_inode = NULL;
 		list_del_init(&dentry->d_alias);
+		dentry->d_flags &= ~DCACHE_INOTIFY_PARENT_WATCHED;
 		spin_unlock(&dentry->d_lock);
 		spin_unlock(&dcache_lock);
 		if (!inode->i_nlink)
_


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/