Re: [PATCH] leave APIC code inactive by default on i386

From: Darrick J. Wong
Date: Wed Mar 01 2006 - 18:27:24 EST


On Wed, 2006-03-01 at 17:51 -0500, Dave Jones wrote:
> On Wed, Mar 01, 2006 at 02:47:38PM -0800, Darrick J. Wong wrote:
> > On Wed, 2006-03-01 at 17:14 -0500, Dave Jones wrote:
> >
> > > In light of Matthew's comments in this thread though, I'm also wondering
> > > if we can now get by without this diff, and just enable it by default now
> > > that the kernel respects that the BIOS and leaves it alone if it's been
> > > disabled.
> >
> > Actually, it seems that there are Lenovo ThinkCenter P4 machines with
> > buggy BIOSes that tell us that we can enable the APIC ... but doing so
> > eventually causes the system to hang. Granted, the Google-recommended
> > fixes are "noapic" or "Update the BIOS", but perhaps it would be best to
> > leave it off _except_ for the few cases where we know that we need it.
> >
> > (Then again, the correct solution in this case is to fix the BIOS...)
>
> Indeed. And also blacklist the bad ones with DMI entries.

Yeah. Since the kernel honors the BIOS's APIC settings, we might as
well enable the APIC code by default.

--D

Attachment: signature.asc
Description: This is a digitally signed message part