Re: 2.6.16-rc5-mm1

[Andrew Morton]

Mike Galbraith <efault@xxxxxx> wrote:
>
> On Wed, 2006-03-01 at 15:50 +0100, Laurent Riffard wrote:
> >  
> > 

OK, thanks guys.  Eric, could you please cook up something to make the
permissions appear-to-work as expected?

> > 2.6.16-rc5-mm2-pre1 works fine for me except numerous "BUG: warning at fs/inotify.c:533/inotify_d_instantiate()".
> 
> I feel left out.  I get none.
> 

Maybe you're not running applications which install inotify watches.  This
is apparently triggerable by doing `touch foo;rm foo;touch foo' in a watched
directory.

Nick, isn't it simply a matter of..

--- devel/fs/dcache.c~inotify-lock-avoidance-with-parent-watch-status-in-dentry-fix	2006-03-01 12:10:48.000000000 -0800
+++ devel-akpm/fs/dcache.c	2006-03-01 12:11:33.000000000 -0800
@@ -173,6 +173,7 @@ repeat:
 		goto kill_it;
   	if (list_empty(&dentry->d_lru)) {
   		dentry->d_flags |= DCACHE_REFERENCED;
+		dentry->d_flags &= DCACHE_INOTIFY_PARENT_WATCHED;
   		list_add(&dentry->d_lru, &dentry_unused);
   		dentry_stat.nr_unused++;
   	}
_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/