Re: [patch 10/39] [PATCH] i386/x86-64: Dont IPI to offline cpus onshutdown

From: Eric W. Biederman
Date: Tue Feb 28 2006 - 02:08:42 EST


Chris Wright <chrisw@xxxxxxxxxxxx> writes:

> * Andi Kleen (ak@xxxxxxx) wrote:
>> On Monday 27 February 2006 23:32, Chris Wright wrote:
>> > -stable review patch. If anyone has any objections, please let us know.
>> > ------------------
>> >
>> > So why are we calling smp_send_stop from machine_halt?
>>
>> I don't think that one is really suitable for stable since it's
>> a relative obscure problem and the fix is not fully clear. Also it might
>> have side effects. Shouldn't be merged.
>
> This was sent in by both Andrew and Ashok, and is upstream (although Eric
> notes there's more to the comprehensive solution). It allegedly solves:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=6077
>
> Although the reporter seems to have gone silent. Unless there's some
> compelling evidence otherwise, I'm happy to drop it.

The comprehensive fix for 2.6.15.x is to remove -p from /sbin/halt
if your machine has this problem. I have just updated the bugzilla
entry so we can remember this.

There are no security implications to this, either since this is a crash
when attempting to power off the machine.

Eric

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/