Re: LibPATA code issues / 2.6.15.4
From: Jeff Garzik
Date: Mon Feb 27 2006 - 21:50:19 EST
Linus Torvalds wrote:
On Mon, 27 Feb 2006, Jeff Garzik wrote:
I've had this waiting in the wings, in fact... [see attached]
I really hate having a _global_ variable called "fua". That's just bad
taste. I would suggest calling it "atapi_forced_unit_attention_enabled",
but maybe that is going a bit overboard. It's definitely better than just
"fua", though.
<shrug> It will go away when things are fixed, and only users who are
testing will even bother with it.
Looking over the module subsystem, it looks like one could use
module_param_named() to achieve proper namespace separation (C versus
module opt) -- then you could call it libata_fua -- but for a temporary
module option it seems like more trouble than its worth.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/