Re: [PATCH 2/7] isdn4linux: Siemens Gigaset drivers - event layer

From: Arjan van de Ven
Date: Mon Feb 27 2006 - 03:00:51 EST


On Mon, 2006-02-27 at 07:23 +0100, Hansjoerg Lipp wrote:
> + }
> +
> + spin_lock_irqsave(&cs->lock, flags);
> + ret = kmalloc(sizeof(struct at_state_t), GFP_ATOMIC);
> + if (ret) {
> + gigaset_at_init(ret, NULL, cs, cid);
>

if you move the kmalloc one line up, can it use GFP_KERNEL ?
(GFP_ATOMIC is evil in the sense that spurious use of it gives trouble
for the VM)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/