Re: [-mm patch] net/dccp/ipv4.c: make struct dccp_v4_prot static

[Arnaldo Carvalho de Melo]

On 2/25/06, Adrian Bunk <bunk@xxxxxxxxx> wrote:
> On Fri, Feb 24, 2006 at 03:10:02AM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.16-rc4-mm1:
> >...
> >  git-net.patch
> >...
> >  git trees.
> >...
>
>
> There's no reason for struct dccp_v4_prot being global.
>
>
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
>
> --- linux-2.6.16-rc4-mm2-full/net/dccp/ipv4.c.old       2006-02-25 04:32:45.000000000 +0100
> +++ linux-2.6.16-rc4-mm2-full/net/dccp/ipv4.c   2006-02-25 04:32:53.000000000 +0100
> @@ -1022,7 +1022,7 @@
>         .twsk_obj_size  = sizeof(struct inet_timewait_sock),
>  };
>
> -struct proto dccp_v4_prot = {
> +static struct proto dccp_v4_prot = {
>         .name                   = "DCCP",
>         .owner                  = THIS_MODULE,
>         .close                  = dccp_close,

Heck, the last series of patches were exactly to separate ipv4/ipv6 in
DCCP more clearly, how could I forget the cherry on top (sticking this static
in front of dccp_v4_prot)?

Eagle eyes indeed.

Thanks.

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/