Re: Areca RAID driver remaining items?

[Matthew Wilcox]

On Fri, Feb 24, 2006 at 09:03:47AM -0800, Randy.Dunlap wrote:
> On Fri, 24 Feb 2006, Christoph Hellwig wrote:
> > Please avoid that unless really nessecary.  I doubt there's boards where
> > MSI would only be broken with the areca card but not with other MSI-capable
> > ones.  If a board or chipset is generally broken vs MSI it should be
> > added to the global MSI blacklist.  It's probably be nice to have a global
> > nomsi boot option instead of one in every driver aswell..
> 
> http://www.xenotime.net/linux/patches/pci_nomsi.patch adds a
> global boot option to disable MSI interrupt assignments.

I like it.  How about adding pci=nomsi instead of pci_nomsi?

--- drivers/pci/pci.c   4 Feb 2006 04:51:55 -0000       1.28
+++ drivers/pci/pci.c   24 Feb 2006 19:33:25 -0000
@@ -900,8 +900,12 @@ static int __devinit pci_setup(char *str
                if (k)
                        *k++ = 0;
                if (*str && (str = pcibios_setup(str)) && *str) {
-                       /* PCI layer options should be handled here */
-                       printk(KERN_ERR "PCI: Unknown option `%s'\n", str);
+                       if (!strcmp(str, "nomsi")) {
+                               pci_msi_enable = 0;
+                       } else {
+                               printk(KERN_ERR "PCI: Unknown option `%s'\n",
+                                               str);
+                       }
                }
                str = k;
        }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/